fix: do not sleep before checking for the reloaded action status #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
wait_until_finished-fix
branch
2 times, most recently
from
923cdcf
to
fe807e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 64 64
Lines 2957 2960 +3
=======================================
+ Hits 2753 2756 +3
Misses 204 204 ☔ View full report in Codecov by Sentry. |
jooola
force-pushed
the
wait_until_finished-fix
branch
from
fe807e0
to
664d81a
Compare
apricote
approved these changes
Jul 25, 2024
jooola
pushed a commit
that referenced
this pull request
Jul 30, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.1](v2.1.0...v2.1.1) (2024-07-30) ### Bug Fixes * do not sleep before checking for the reloaded action status ([#426](#426)) ([3e0a85b](3e0a85b)) * mark client retry backoff function as static ([#429](#429)) ([14ed130](14ed130)) ### Documentation * add api changes note in changelog ([#424](#424)) ([5cbe188](5cbe188)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not sleep before checking for the reloaded action status.