Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to tooltip text #13

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Revisions to tooltip text #13

merged 1 commit into from
Aug 28, 2019

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Aug 23, 2019

@vincerubinetti
Copy link
Collaborator

@dhimmel How critical are these changes. It looks like that eslint bug is finally fixed and an update version should be rolling out soon (maybe a couple of days?), and I was thinking about waiting for that to update the tooltips.

@dhimmel
Copy link
Member Author

dhimmel commented Aug 26, 2019

It looks like that eslint bug is finally fixed and an update version should be rolling out soon

fine to wait

@vincerubinetti
Copy link
Collaborator

@dhimmel are you sure this is all you found. Remember these particular tooltips are not shared across repurpose-frontend and disease-genes-frontend.

Also, no changes in the text above/below the apps, in het.io?

@dhimmel
Copy link
Member Author

dhimmel commented Aug 28, 2019

are you sure this is all you found

I think this is all I have for hetio/disease-genes-frontend. I may make another PR to update the text above the app on https://het.io/disease-genes/, but that will be in a PR to a separate repo.

@vincerubinetti vincerubinetti merged commit a8b9171 into master Aug 28, 2019
@vincerubinetti vincerubinetti deleted the tooltip-revisions branch August 28, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants