Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Heroku-24 #189

Merged
merged 8 commits into from
May 17, 2024
Merged

Add support for Heroku-24 #189

merged 8 commits into from
May 17, 2024

Conversation

brahyt-sf
Copy link
Contributor

@brahyt-sf brahyt-sf commented May 15, 2024 •
edited
Loading

binary was created using make build-heroku-24
Ticket: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001geKclYAE/view

🕙[ 07:15:22 ] ➜ git push heroku main
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 10 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 279 bytes | 279.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0), pack-reused 0
remote: Updated 82 paths from f83e77f
remote: Compressing source files... done.
remote: Building source:
remote: Waiting on build...
remote: Waiting on build... (elapsed: 6s)
remote: Waiting on build... (elapsed: 9s)
remote: Waiting on build... (elapsed: 12s)
remote:
remote: -----> Building on the Heroku-24 stack
remote: -----> Using buildpack: https://github.com/heroku/heroku-buildpack-pgbouncer.git#add-support-for-heroku-24
remote: -----> pgbouncer app detected
remote: -----> pgbouncer-buildpack: Vendoring pgbouncer into slug
remote: -----> pgbouncer-buildpack: Installed pgbouncer 1.17.0
remote: -----> pgbouncer-buildpack: Moving the configuration generation script into app/bin
remote: -----> pgbouncer-buildpack: Moving the start-pgbouncer script into app/bin
remote: -----> pgbouncer-buildpack: Moving the (legacy) start-pgbouncer-stunnel script into app/bin
remote: -----> pgbouncer-buildpack: Moving the use-pgbouncer script into app/bin
remote: -----> pgbouncer-buildpack: done
remote: -----> Discovering process types
remote:        Procfile declares types -> (none)
remote:
remote: -----> Compressing...
remote:        Done: 793.9K
remote: -----> Launching...
remote:        Released v9
remote:        https://brahyt-dev-24-b8ed0d72251a.herokuapp.com/ deployed to Heroku
remote:
remote: Verifying deploy... done.
To https://git.heroku.com/brahyt-dev-24.git

@brahyt-sf brahyt-sf requested a review from edmorley May 15, 2024 22:50
@mble-sfdc
Copy link
Contributor

@brahyt-sf Unfortunately, the binary you have pushed is built for arm64, not amd64, so this won't work. Lets talk more about this :)

edmorley
edmorley reviewed May 17, 2024
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@edmorley
Copy link
Member

Thank you for working on this! 😄

@brahyt-sf brahyt-sf marked this pull request as ready for review May 17, 2024 16:23
edmorley
edmorley approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@brahyt-sf brahyt-sf merged commit f1c70d3 into main May 17, 2024
6 checks passed
@brahyt-sf brahyt-sf deleted the add-support-for-heroku-24 branch May 17, 2024 22:03
@edmorley edmorley mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brahyt-sf @mble-sfdc @edmorley