add Mongodb protocol ParseStream() #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 11:05
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
hengyoush
reviewed
Jan 6, 2025
| @@ -83,3 +87,55 @@ func (d *BinaryDecoder) ExtractByte() (byte, error) { | |||
| d.readBytes++ | |||
| return x, nil | |||
| } | |||
|
|
|||
| func ExtractBEInt[TIntType int32 | uint32 | uint8](d *BinaryDecoder) (TIntType, error) { | |||
There was a problem hiding this comment.
We should add some unit tests for these utility functions.
| } | ||
|
|
||
| // FormatToSummaryString implements protocol.ParsedMessage. | ||
| func (m *MongoDBFrame) FormatToSummaryString() string { |
There was a problem hiding this comment.
This method has already been removed in the latest code. You might want to rebase onto the current main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先把目前修改的ParseStream推上来试试 大佬有空可以先看看 我争取这周能理清并跑通整个MongoDB的协议解析