Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce query executor strategy, enabling #165 #174

Merged
merged 3 commits into from
Apr 22, 2014

Conversation

YannRobert
Copy link
Collaborator

This is a refactoring.
This change has no impact on runtime.

This permits to easily change the implementation of StdCouchDbConnector.executeQuery(ViewQuery, ResponseCallback)
It should therefore enable #165 to be fixed in a non intrusive way.

@YannRobert
Copy link
Collaborator Author

TravisCI failed on unit test that has nothing to do with the change

@helun
Copy link
Owner

helun commented Apr 22, 2014

LegacyQueryExecutor? How about DefaultQueryExecutor? Names such as LegacyX makes the codebase feel rotten and cumbersome...

@YannRobert
Copy link
Collaborator Author

I agree that Legacy sounds bad.
I was on Default... at the beginning, but had the feeling is would encourage new users to use it whatever new or better alternative may come up in the next ... years.
Any other option you can think of ?

@helun
Copy link
Owner

helun commented Apr 22, 2014

It is the default, is it not? And it will always work, although not optimal costwise in the cloudant case.
We could either create a CloudantConnectorFactory that creates a connector configured for cloudant and/or capture this in the docs.

@YannRobert
Copy link
Collaborator Author

Renamed it to DefaultQueryExecutor.

…plementation of StdCouchDbConnector.executeQuery(ViewQuery, ResponseCallback) to new class DefaultQueryExecutor that is used by default. This should greatly improve the ability to change the default behavior in a non intrusive way
…ntations can get the URI object and eventually change it before turning it into a String
@YannRobert
Copy link
Collaborator Author

rebased from master + squashed class renaming and comments fix

helun pushed a commit that referenced this pull request Apr 22, 2014
Introduce query executor strategy, enabling #165
@helun helun merged commit bb3b3f2 into helun:master Apr 22, 2014
@ceefour
Copy link
Contributor

ceefour commented Apr 22, 2014

@helun @YannRobert Thanks :) Now I can wait for 1.4.2 release :)

@ceefour
Copy link
Contributor

ceefour commented Sep 18, 2014

@YannRobert @helun 1.4.2 changes are not sufficient to implement my own QueryExecutor properly.

Please review #192 for the additional changes required.

@YannRobert YannRobert deleted the IntroduceQueryExecutorStrategy branch February 10, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants