-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce query executor strategy, enabling #165 #174
Introduce query executor strategy, enabling #165 #174
Conversation
TravisCI failed on unit test that has nothing to do with the change |
LegacyQueryExecutor? How about DefaultQueryExecutor? Names such as LegacyX makes the codebase feel rotten and cumbersome... |
I agree that Legacy sounds bad. |
It is the default, is it not? And it will always work, although not optimal costwise in the cloudant case. |
Renamed it to DefaultQueryExecutor. |
…plementation of StdCouchDbConnector.executeQuery(ViewQuery, ResponseCallback) to new class DefaultQueryExecutor that is used by default. This should greatly improve the ability to change the default behavior in a non intrusive way
…ntations can get the URI object and eventually change it before turning it into a String
rebased from master + squashed class renaming and comments fix |
Introduce query executor strategy, enabling #165
@helun @YannRobert Thanks :) Now I can wait for 1.4.2 release :) |
@YannRobert @helun 1.4.2 changes are not sufficient to implement my own Please review #192 for the additional changes required. |
This is a refactoring.
This change has no impact on runtime.
This permits to easily change the implementation of StdCouchDbConnector.executeQuery(ViewQuery, ResponseCallback)
It should therefore enable #165 to be fixed in a non intrusive way.