Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove CT_CONFIG_DIR #150

Closed
wants to merge 1 commit into from
Closed

fix: remove CT_CONFIG_DIR #150

wants to merge 1 commit into from

Conversation

znd4
Copy link

@znd4 znd4 commented Jun 6, 2024

This fixes #108

If there are other things in ${cache_dir}/etc/ct.yaml, can we set them as individual environment variables?

It's a feel bad that this action doesn't work with the default in-repo ct.yaml locations

Fixes helm#108 

Signed-off-by: Zane Dufour <[email protected]>
@jhollowayjc
Copy link

jhollowayjc commented Jun 17, 2024

Hopefully useful: When I try this I get:

ct lint --target-branch main
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/TheJumpCloud/charts/actions/runs/9550292830/job/26321903569#step:5:3).12.4/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.[4](https://github.com/TheJumpCloud/charts/actions/runs/9550292830/job/26321903569#step:5:4)/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.4/x[6](https://github.com/TheJumpCloud/charts/actions/runs/9550292830/job/26321903569#step:5:6)4
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.4/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.4/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.4/x64/lib
    VIRTUAL_ENV: /opt/hostedtoolcache/ct/3.11.0/amd64/venv
Error: failed loading configuration: 'chart_schema.yaml' neither specified nor found in default locations
Linting charts...
failed loading configuration: 'chart_schema.yaml' neither specified nor found in default locations

@znd4
Copy link
Author

znd4 commented Aug 4, 2024

Hmm I see that the other files are necessary. Maybe chart-testing should have an alternative config field for just yamllint / yamale? either way, this PR obvs isn't gonna work

@znd4 znd4 closed this Aug 4, 2024
@znd4 znd4 deleted the patch-1 branch August 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No chart changes detected
2 participants