Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE URL from API when private #428

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattclegg
Copy link
Contributor

@cpanato I'd like to support using the URL from the API instead of the BrowserDownloadURL as that appears to be the only one that supports personal access tokens on private repos.

ref

@mattclegg mattclegg force-pushed the USE-URL-from-API-when-private branch from afc8918 to b0489e2 Compare July 2, 2024 15:43
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 2, 2024
@cpanato
Copy link
Member

cpanato commented Jul 2, 2024

What is the motivation for that? Sorry, I did not quite understand that.

Also what is the relation with the link you added with this PR?

@mattclegg
Copy link
Contributor Author

I'm trying to use a chart that has been published to a private GitHub repository. The BrowserDownloadURL from GitHub API doesn't work with "personal access tokens" (which I need to access to the private repository).

The reference to the link is because I've also had to update the helm binary to send the correct headers when downloading the chart from a private GitHub repository.

So now I just need to update index.yaml to use; https://api.github.com/repos/$OWNER/$REPO/releases/assets/$ASSET_ID

Signed-off-by: Matt Clegg <[email protected]>
@KrisJohnstone
Copy link

+1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants