Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIDY unused packages-with-index HTTPClient #420

Merged
merged 1 commit into from
Jun 21, 2024
Merged

TIDY unused packages-with-index HTTPClient #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions pkg/releaser/releaser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"fmt"
"io"
"math/rand"
"net/http"
"net/url"
"os"
"path/filepath"
Expand Down Expand Up @@ -53,11 +52,6 @@ type GitHub interface {
CreatePullRequest(owner string, repo string, message string, head string, base string) (string, error)
}

type HTTPClient interface {
Get(url string) (*http.Response, error)
GetWithToken(url string, token string) (*http.Response, error)
}

type Git interface {
AddWorktree(workingDir string, committish string) (string, error)
RemoveWorktree(workingDir string, path string) error
Expand All @@ -68,8 +62,6 @@ type Git interface {
GetPushURL(remote string, token string) (string, error)
}

type DefaultHTTPClient struct{}

var letters = []rune("abcdefghijklmnopqrstuvwxyz0123456789")

const chartAssetFileExtension = ".tgz"
Expand All @@ -78,10 +70,6 @@ func init() {
rand.New(rand.NewSource(time.Now().UnixNano())) // nolint: gosec
}

func (c *DefaultHTTPClient) Get(url string) (resp *http.Response, err error) {
return http.Get(url) // nolint: gosec
}

type Releaser struct {
config *config.Options
github GitHub
Expand Down