This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
allows passing key config values directly to supervisors in tests #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
reviewed
Mar 1, 2022
| @@ -937,7 +937,7 @@ config_node({Miner, {TCPPort, UDPPort, JSONRPCPort}, ECDH, PubKey, _Addr, SigFun | |||
| ct_rpc:call(Miner, application, set_env, [lager, metadata_whitelist, [poc_id]]), | |||
|
|
|||
| %% set blockchain configuration | |||
| Key = {PubKey, ECDH, SigFun}, | |||
| Key = #{pubkey => PubKey, ecdh_fun => ECDH, sig_fun => SigFun}, | |||
There was a problem hiding this comment.
sure no side effects of the Key format changing to a map ? ie other consumers of application:get_env(blockchain, key)
There was a problem hiding this comment.
i can't find any; we only ever set that value one time (in the config_node/2 in the ct_utils setup) and otherwise it's whatever is in sys.config.
this only place i can see this will cause problems is here which you would only encounter if you're trying to inject pre-built pubkey/signing functions and enabling the embedded gateway-rs and since gateway-rs is supposed to handle all key stuffs when it's turned on i'm not sure that's a valid scenario to worry about anyway
|
Confirming my POC test suite is working again with this change |
andymck
approved these changes
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many common test setups rely on explicitly pre-generating the critical ecc key details, pubkey, ecdh function and signing function, and passing them directly to the application supervisors at startup. This change allows the
miner_keys:keys/0to accept and passthrough these test-case config overrides directly to the processes that expect them.