This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
On-chain patch to PoC spreading factor choice #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mutually exclusive with helium/miner#1865
@mikev says:
Recently we've taken a close look at PoC in the context of AS923. Network observations show that AS923 PoC is beaconing at SF9. As a comparison EU868 successfully beacons at SF12. We looked deeper into the Miner's PoC code and believe this is incorrect. The spec allows 400ms dwell time regions, such as AS923, to use the SF12 datarate for packets 59 bytes and smaller. Our current PoC packets are 52 bytes.
We propose a minor patch to enable the AS923 regions to PoC beacon at the SF12 datarate. This will have the effect of approximately doubling the PoC distance range. The PoC distance range roughly matches the distance a LoRa sensor can achieve when it sends it's initial Join request at SF12.