Allow fractional shares (#445)

* Allow fractional shares * Allow fractional shares
hectorgomezv · Apr 14, 2024 · 039b8dc · 039b8dc
1 parent 481a763
commit 039b8dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/portfolios/domain/dto/test/upsert-position-dto.factory.ts b/src/portfolios/domain/dto/test/upsert-position-dto.factory.ts
@@ -9,8 +9,8 @@ export function upsertPositionDtoFactory(
 ): UpsertPositionDto {
   return <UpsertPositionDto>{
     symbol: symbol ?? faker.word.words(),
-    targetWeight: targetWeight ?? faker.number.int({ min: 5, max: 10 }),
-    shares: shares ?? faker.number.int({ min: 10, max: 100 }),
+    targetWeight: targetWeight ?? faker.number.float({ min: 5, max: 10 }),
+    shares: shares ?? faker.number.float({ min: 10, max: 100 }),
     blocked: blocked ?? faker.datatype.boolean(),
   };
 }
diff --git a/src/portfolios/routes/dto/upsert-position.dto.ts b/src/portfolios/routes/dto/upsert-position.dto.ts
@@ -1,5 +1,5 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsBoolean, IsInt, IsPositive, IsString } from 'class-validator';
+import { IsBoolean, IsPositive, IsString } from 'class-validator';
 import { UpsertPositionDto as DomainUpsertPositionDto } from '../../domain/dto/upsert-position.dto';
 
 export class UpsertPositionDto implements DomainUpsertPositionDto {
@@ -10,7 +10,7 @@ export class UpsertPositionDto implements DomainUpsertPositionDto {
   @IsPositive()
   targetWeight: number;
   @ApiProperty()
-  @IsInt()
+  @IsPositive()
   shares: number;
   @ApiProperty()
   @IsBoolean()