This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
adds support for timestamp #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pwnall would be great to get this merged! 😍 |
|
@thatandyrose I am not a collaborator on this repo anymore. Perhaps @enochcheung can help? The change LGTM, with the nit that I'd prefer "ISO 8601" in strings. |
|
@hwhelchel According to Travis this change breaks tests in Ruby 1.8 through 2.0, as well as jruby-9. This would need to be resolved before we can merge (which we would like to do!) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.