frontend: CustomResourceInstancesList: Fix to work with multi cluster #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: René Dudfield <[email protected]>
dosubot
bot
added
the
size:S
illume
added
bug
joaquimrocha
requested changes
Nov 8, 2024
Comment on lines
+13
to
+17
| const dataClassCrds = crds.map(crd => { | ||
| const crdClass = crd.makeCRClass(); | ||
| const data = crdClass.useList({ cluster: crd.cluster }); | ||
| return { data, crdClass, crd }; | ||
| }); |
There was a problem hiding this comment.
Should we keep a useMemo for at least generating the classes here?
There was a problem hiding this comment.
I don't think so. I had tried that, but generating the classes doesn't take very much time.
If it's a problem for you, and not a nit... I can have a bit more of a think.
The issue is the view completely failed to render. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before there was an error, now they list and there is a cluster column.
(for single cluster mode it's the same as before)