frontend: ClusterNotFoundPopup: Fix to work with multi clusters #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
illume
added
bug
Now when there's a wrong cluster name in the URL when using multiple clusters it also gives a cluster not found alert message for each cluster not found. Signed-off-by: René Dudfield <[email protected]>
joaquimrocha
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Does this show a popup per cluster? I think this UX could be unnerving for the user. I had actually disabled the popup when in multi-cluster.
c42f7b2
Can't remember exactly but I think I had tried to add the cluster problems in the main view, to be expanded at will.
|
I don't think completely disabling the alert is a good idea. It's most likely every single cluster won't break at the same time. How about:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when there's a wrong cluster name in the URL when using multiple clusters it also gives a cluster not found alert message for each cluster not found.
How to test