Upgrade to Java 11 [HZ-3617] #289
Conversation
.gitattributes
Outdated
| # linux line-endings | ||
| * text eol=lf |
There was a problem hiding this comment.
This doesn't seem to be correct. Why force all files to be text? And why not allow git to convert text files to platform-specific line endings?
There was a problem hiding this comment.
I thought having explicit configuration instead of relying on the user's git configuration would be better. User may not have configured his git for automatic line ending.
There was a problem hiding this comment.
I still think this is wrong. Windows users will see the sources with wrong file-endings in their working tree. At least it's how I understand the explanation in https://git-scm.com/docs/gitattributes
| SqlResult sqlResult = member.getSql() | ||
| .execute("create view emp_dept_view as select * from emp join dept on emp.age=dept.__key"); | ||
| sqlResult.close(); | ||
| Connection connection = DriverManager.getConnection(JDBC_HAZELCAST_LOCALHOST); |
There was a problem hiding this comment.
Where is this connection closed?
.gitattributes
Outdated
| # linux line-endings | ||
| * text eol=lf |
There was a problem hiding this comment.
I still think this is wrong. Windows users will see the sources with wrong file-endings in their working tree. At least it's how I understand the explanation in https://git-scm.com/docs/gitattributes
|
@kwart I have reverted .gitattributes file |
Co-authored-by: Josef Cacek <[email protected]>
Co-authored-by: Josef Cacek <[email protected]>
|
@kwart applied suggested maven compiler changes |
| <dependency> | ||
| <groupId>org.junit.platform</groupId> | ||
| <artifactId>junit-platform-commons</artifactId> | ||
| <artifactId>junit-jupiter</artifactId> |
Upgrade to Java 11
Upgrade various maven plugins
Upgrade Mockio version
Upgrade Jupiter version
Fix warnings in unit tests
Jira : https://hazelcast.atlassian.net/browse/HZ-3617