get rid of grep warning #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se for the chosen engine (basic, extended or perl). this was added around gnu grep 3.8 anyway, for the regular expression to check if we run under docker no flag is given so we run the basic regex engine, and in the basic engine forward slash has no special meaning and does not need to be escaped by a backslash. gets rid of: grep: warning: stray \ before /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent versions of gnu grep might complain if your regex makes no sense for the chosen engine
(basic, extended or perl). this was added around gnu grep 3.8
anyway, for the regular expression to check if we run under docker no flag is given so we run the basic regex engine, and in the basic engine forward slash has no special meaning and does not need to be escaped by a backslash.
gets rid of:
grep: warning: stray \ before /
egrep/fgrep are also on their last legs; see https://www.gnu.org/software/grep/manual/html_node/Usage.html item 17 & should be changed to grep -E / -F, warnings for not doing so might be added soon as well.