Inline workspace-level directives to make Crane happy. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crane does not properly inline workspace-level directives in all situations, which means that the version information is not available to it once it's constructed a derivation for each crate. This becomes an issue once we use ndc-postgres as a library. We can work around this problem by not using workspace-level directives, copying and pasting the information instead.
danieljharvey
approved these changes
Nov 14, 2023
|
FWIW I tried to debug it in Crane and got very lost. |
SamirTalwar
added a commit
that referenced
this pull request
Feb 27, 2024
This reverts commit 991f25f.
SamirTalwar
added a commit
that referenced
this pull request
Feb 27, 2024
This reverts commit 991f25f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Crane does not properly inline workspace-level directives in all situations, which means that the version information is not available to it once it's constructed a derivation for each crate.
This becomes an issue once we use ndc-postgres as a library.
How
We can work around this problem by not using workspace-level directives, copying and pasting the information instead.