Skip to content

Commit

Permalink
Simplify the Docker image tag and disable releases to DDN for now. (#88)
Browse files Browse the repository at this point in the history
### What

This removes the timestamp from the Docker image tag.

Docker images are inherently timestamped so we do not need this.

We also disable releases to DDN until we have moved over to the new
image location.

### How

Deleting code, mostly.
  • Loading branch information
SamirTalwar authored Oct 19, 2023
1 parent 8faaebb commit 93ef55c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 15 deletions.
File renamed without changes.
24 changes: 9 additions & 15 deletions ci/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,28 +44,22 @@ function run {
# Assumes that the given ref is a branch name. Sets a tag for a docker image of
# the form:
#
# dev-main-20230601T1933-bffd555
# --- ---- ------------- -------
# ↑ ↑ ↑ ↑
# prefix "dev" branch | commit hash
# |
# commit date & time (UTC)
# dev-main-bffd555
# --- ---- -------
# ↑ ↑ ↑
# prefix "dev" | commit hash
# branch
#
# Additionally sets a branch tag assuming this is the latest tag for the given
# branch. The branch tag has the form: dev-main
function set_dev_tags {
local branch="$1"
# replace '/' in branch name with '-'
# replace '.' and '/' in branch name with '-'
local tidy_branch
tidy_branch="$(echo "${branch}" | tr "//" -)"
local branch_prefix="dev-$tidy_branch"
tidy_branch="$(tr './' '-' <<< "$branch")"
local branch_prefix="dev-${tidy_branch}"
local version
version=$(
TZ=UTC0 git show \
--quiet \
--date='format-local:%Y%m%dT%H%M' \
--format="$branch_prefix-%cd-%h"
)
version=$(git show --quiet --format="${branch_prefix}-%h")
export docker_tags=("$version" "$branch_prefix")
}

Expand Down

1 comment on commit 93ef55c

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Component benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 93ef55c Previous: 8faaebb Ratio
select-where - request time - (query + acquisition) 11.972216994445503 ms 4.992232167868238 ms 2.40
select - request time - (query + acquisition) 27.6359843103952 ms 7.286586573365511 ms 3.79

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.