Implement trace propagation #49
Conversation
| @@ -331,10 +333,7 @@ where | |||
| }); | |||
|
|
|||
| router | |||
| .layer( | |||
| TraceLayer::new_for_http() | |||
| .make_span_with(DefaultMakeSpan::default().level(Level::INFO)), | |||
There was a problem hiding this comment.
Removing this make_span_with means we default to the default TraceLayer implementation, which makes all error responses into error traces rather than always INFO, solving #43
Info: https://docs.rs/tower-http/latest/tower_http/trace/struct.TraceLayer.html#method.new_for_http
| pub struct PropagateParentTraces; | ||
|
|
||
| impl<B> MakeSpan<B> for PropagateParentTraces { | ||
| fn make_span(&mut self, req: &Request<B>) -> Span { |
There was a problem hiding this comment.
This grabs the W3 trace header (ie, traceheader and tracestate) and adds them to the context of any spans we create, meaning we can follow between services.
danieljharvey
changed the title
| @@ -0,0 +1,23 @@ | |||
| # re-build on code changes, and run the reference agent each time a build is | |||
There was a problem hiding this comment.
A few quality-of-life just commands. Happy to move these into a separate PR if needed.
|
Just realised there is already an implementation in |
|
Closing in favour of #51 |
This PR implements trace propagation, adds a
MakeSpantrait that grab anytraceparentandtracestateheaders, and injecting them into span context. The result is that requests fromv3-engineshow up in NDC agents as follows: