Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prefer-oldest documentation #8904

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix prefer-oldest documentation #8904

merged 1 commit into from
Apr 20, 2023

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Apr 14, 2023

Available since 3.10, not 3.8.
Closes #8656

Please include the following checklist in your PR:

Bonus points for added automated tests!

Mikolaj
Mikolaj approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Why not backport this fix?

@ffaf1 ffaf1 added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Apr 14, 2023
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Apr 14, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 16, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Apr 19, 2023

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

rebase

✅ Branch has been successfully rebased

@Mikolaj Mikolaj mentioned this pull request Apr 19, 2023
Merged
@Mikolaj
Copy link
Member

Mikolaj commented Apr 19, 2023

The CI failure is a new CI problem, unrelated to this PR.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 20, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

refresh

✅ Pull request refreshed

@Mikolaj
Copy link
Member

Mikolaj commented Apr 20, 2023

@mergify unqueue

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

unqueue

☑️ The pull request is not queued

@Mikolaj
Copy link
Member

Mikolaj commented Apr 20, 2023

@mergify rebase

@ffaf1 @Mikolaj
Fix prefer-oldest documentation
7b40528 
Available since 3.10, not 3.8.
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit df0030d into haskell:master Apr 20, 2023
@mergify mergify bot mentioned this pull request Apr 20, 2023
Merged
@ffaf1 ffaf1 deleted the doc-prefer-oldest branch May 4, 2023 16:32
mergify bot added a commit that referenced this pull request Sep 4, 2023
@mergify
Merge pull request #8913 from haskell/mergify/bp/3.10/pr-8904
1714b07 
Fix `prefer-oldest` documentation (backport #8904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes

@Kleidukos Kleidukos Kleidukos approved these changes

Assignees
No one assigned
Labels
documentation merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation inaccurately claims that --prefer-oldest is supported since v3.8
3 participants
@ffaf1 @Mikolaj @Kleidukos