-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate cabal format
#10469
base: master
Are you sure you want to change the base?
Deprecate cabal format
#10469
Conversation
8f31ad3
to
8792d40
Compare
e508270
to
4f89b40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
synopsis: Deprecate `cabal format` | ||
packages: cabal-install | ||
prs: #10469 | ||
significance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a significant change, please add the significant
metadata to this field.
I oppose this because we have had multiple projects in flight for years to get a working exact-printer format could make use of. I suppose once we get one, we can bring this command back done "right" but i don't see a point to this in the meantime... Just seems make-work for no reason? |
, hiddenCmd actAsSetupCommand actAsSetupAction | ||
, hiddenCmd manpageCommand (manpageAction commandSpecs) | ||
, regularCmd CmdListBin.listbinCommand CmdListBin.listbinAction | ||
, hiddenCmd dumpPackageDescriptionCommand dumpPackageDescriptionAction | ||
] | ||
++ concat | ||
[ newCmd CmdConfigure.configureCommand CmdConfigure.configureAction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by moving format from hidden to regular doesn't this make things worse, not better?
cabal format
was never production ready, and it is mistakenly used to format cabal files. I kept the functionality ascabal dump-package-description
because I still think it might be useful.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
Manual QA notes have been included.Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)