-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hashable dependency #10316
base: master
Are you sure you want to change the base?
Remove hashable dependency #10316
Conversation
bf37272
to
19ab916
Compare
7c4b075
to
9dd2457
Compare
Removing hashable from the test suite nerd-sniped me into writing a bit of whacky arbitrary machinery, but I think it's not necessarily worse than abusing hashable for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool, thank you!
I'd hope for a smaller diff if we just had some of the compat code added to some sort of Prelude or Compat module (which we already have in vast numbers!). So, like
type Hash = HashValue
readFileHash = readFileHashValue
But maybe this grows the codebase unnecessarily, so I'm split on this. It just feels like a hash library is something that may change once in a while, and a little abstraction from it woudln't hurt.
1618320
to
46c15ca
Compare
I added some minimal comments to the code as well.
IMO, |
Oh, that's good, thank you! |
See #10140