Merge pull request #1 from hashicorp/ecr-pull-fixup

Docs and changelog

.changelog/4847.txt

@@ -0,0 +1,3 @@
+```release-note:improvement
+plugin/aws/ecr-pull: Support entrypoint injection in ecr-pull builder
+```

builtin/aws/ecr/pull/builder.go

@@ -17,6 +17,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	awsecr "github.com/aws/aws-sdk-go/service/ecr"
 	"github.com/aws/aws-sdk-go/service/lambda"
+
 	"github.com/hashicorp/waypoint-plugin-sdk/component"
 	"github.com/hashicorp/waypoint-plugin-sdk/docs"
 	"github.com/hashicorp/waypoint-plugin-sdk/terminal"
@@ -116,6 +117,16 @@ build {
 		docs.Default("`\"\"`"),
 	)
 
+	doc.SetField(
+		"disable_entrypoint",
+		"if set, the entrypoint binary won't be injected into the image",
+		docs.Summary(
+			"The entrypoint binary is what provides extended functionality",
+			"such as logs and exec. If it is not injected at build time",
+			"the expectation is that the image already contains it",
+		),
+	)
+
 	return doc, nil
 }
 

builtin/aws/ecr/pull/components/builder/aws-ecr-pull-builder/parameters.hcl

@@ -1,7 +1,7 @@
 # This file was generated via `make gen/integrations-hcl`
 parameter {
   key         = "disable_entrypoint"
-  description = ""
+  description = "if set, the entrypoint binary won't be injected into the image\nThe entrypoint binary is what provides extended functionality such as logs and exec. If it is not injected at build time the expectation is that the image already contains it"
   type        = "bool"
   required    = false
 }

embedJson/gen/builder-aws-ecr-pull.json

@@ -5,6 +5,18 @@
    "mappers": null,
    "name": "aws-ecr-pull",
    "optionalFields": [
+      {
+         "Field": "disable_entrypoint",
+         "Type": "bool",
+         "Synopsis": "if set, the entrypoint binary won't be injected into the image",
+         "Summary": "The entrypoint binary is what provides extended functionality such as logs and exec. If it is not injected at build time the expectation is that the image already contains it",
+         "Optional": true,
+         "Default": "",
+         "EnvVar": "",
+         "Category": false,
+         "Example": "",
+         "SubFields": null
+      },
       {
          "Field": "force_architecture",
          "Type": "string",

website/content/partials/components/builder-aws-ecr-pull.mdx

@@ -48,6 +48,15 @@ The tag of the image to pull.
 
 These parameters are used in the [`use` stanza](/waypoint/docs/waypoint-hcl/use) for this plugin.
 
+#### disable_entrypoint
+
+If set, the entrypoint binary won't be injected into the image.
+
+The entrypoint binary is what provides extended functionality such as logs and exec. If it is not injected at build time the expectation is that the image already contains it.
+
+- Type: **bool**
+- **Optional**
+
 #### force_architecture
 
 **Note**: This is a temporary field that enables overriding the `architecture` output attribute. Valid values are: `"x86_64"`, `"arm64"`.