Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typo in AWS Secrets Engine documentation #28930

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kevin-loehfelm
Copy link
Contributor

Description

Minor documentation update. In Vault 1.16, the AWS secrets engine added a fourth type of credential that can be retrieved but the documentation still says three:

https://developer.hashicorp.com/vault/docs/v1.16.x/secrets/aws

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

In Vault 1.16, AWS secrets engine was updated to support four different types of credentials. The documentation states it only support three, but then lists four. Very minor update to correct the documentation.
@kevin-loehfelm kevin-loehfelm changed the title Aws secrets engine credential types Update typo in AWS Secrets Engine documentation Nov 15, 2024
@kevin-loehfelm kevin-loehfelm marked this pull request as ready for review November 15, 2024 21:18
@kevin-loehfelm kevin-loehfelm requested a review from a team as a code owner November 15, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant