Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform validation when issuing or signing certificates #28921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Nov 15, 2024

Description

Perform validation when issuing or signing certificates.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr added this to the 1.19.0-rc milestone Nov 15, 2024
@victorr victorr self-assigned this Nov 15, 2024
@victorr victorr requested a review from a team as a code owner November 15, 2024 15:05
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr force-pushed the victorr/vault-22013-pki-verify-certificates branch from bc46a87 to dbcf6a5 Compare November 15, 2024 15:15
Copy link

github-actions bot commented Nov 15, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@victorr victorr force-pushed the victorr/vault-22013-pki-verify-certificates branch from dbcf6a5 to 193d3cb Compare November 15, 2024 15:42
Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@victorr victorr force-pushed the victorr/vault-22013-pki-verify-certificates branch 3 times, most recently from 5e43634 to 2afbf98 Compare November 15, 2024 20:42
Add environment variable VAULT_DISABLE_ISSUING_VERIFICATION.

Setting VAULT_DISABLE_ISSUING_VERIFICATION=true will disable the cert
issuance/signing verification.
@victorr victorr force-pushed the victorr/vault-22013-pki-verify-certificates branch from 2afbf98 to 19b3f66 Compare November 15, 2024 20:44
@victorr victorr added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants