-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-31525 Remove lowercasing of RADIUS auth. #28884
base: main
Are you sure you want to change the base?
Conversation
CI Results: |
Build Results: |
@@ -0,0 +1,3 @@ | |||
```release-note:bug | |||
auth/radius: Fixed and issue where upper case items were returning as lower case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth/radius: Fixed and issue where upper case items were returning as lower case. | |
auth/radius: Fixed an issue where usernames with upper case characters where not honored |
We may also want to add a release-note:change
since this is a behavior change that will also result in changes to how policies are assigned
I am not so sure about backporting this. This is a behavior change that could result in negative effects for existing users. RE: usernames are now case sensitive and vault policies may be assigned differently. |
I added the missing |
Description
What does this PR do?
This PR will change the behavior of the RADIUS authentication plugin for Vault. It will now allow for users with capital letters in their usernames to be used within Vault. Previous behavior would return an all lower case user, which would be rejected by the RADIUS server if it was expecting mixed case or all caps.
This was changed due to user reports of issues with capitalization.
Existing usernames that were all lower case will not be affected, but if you use mixed case or all capitals, you will now be able to properly authenticate.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+ent
labels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.x
label, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.