Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds iam:GetUser action for IAM Policy on AWS documentation #28788

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

ollaw
Copy link
Contributor

@ollaw ollaw commented Oct 27, 2024

Description

Updates AWS documentation to correct an omission in IAM permissions policy for Vault, more specifically the IAM Policy with boundary is missing the iam:GetUser action (which is present in the policy above without boundaries), which is also required to perform the root credentials rotation (vault write -f aws/config/rotate-root) when the root user configured starts with Vault, which is likely a common case for beginners.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Copy link

hashicorp-cla-app bot commented Oct 27, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Olla Gabriele <[email protected]>
@ollaw ollaw marked this pull request as ready for review October 27, 2024 23:27
@ollaw ollaw requested a review from a team as a code owner October 27, 2024 23:27
@mpalmi
Copy link
Contributor

mpalmi commented Nov 12, 2024

@ollaw Apologies for the late feedback (after already approving), but would you mind dropping the changelog for this PR? Once you do that I'll go ahead and merge!

Signed-off-by: Olla Gabriele <[email protected]>
@ollaw
Copy link
Contributor Author

ollaw commented Nov 12, 2024

@mpalmi no problem at all, is it fine this way or do I need to rebase?

@mpalmi
Copy link
Contributor

mpalmi commented Nov 12, 2024

@mpalmi no problem at all, is it fine this way or do I need to rebase?

We should be good to go. Thanks for the speedy reply.

@mpalmi mpalmi merged commit ea3002f into hashicorp:main Nov 12, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants