Allow modification of the hostNetwork parameter to avoid the need of …

[shuyanl-qualtrics]

Allow modification of the hostNetwork parameter to avoid the need of a dedicated pod ip.
We would like our daemonsets to run in the hostNetwork so to avoid needing allocate IP for them.
Adding hostNetwork to this template allow us to do this.

[hashicorp-cla-app]

All committers have signed the CLA.

[shuyanl-qualtrics]

Is there any chance this PR can be reviewed by owner?

[tvoran]

Thanks for bringing this up!

In general when adding a new parameter it's best to:

• Set the default in values.yaml, and update values.schema.json
• Add some helm template tests with the parameter set and unset (in test/unit/csi-daemonset.bats in this case)

[shuyanl-qualtrics]

@tvoran Thanks for the review all comment fixed. Please help take a look again.

Can you also review similar PR for CSI-Driver : kubernetes-sigs/secrets-store-csi-driver#1581 Thank you
(also comments in that repo for a question regarding value update)

[tvoran]

This is looking good, just a minor fix in the tests.

[tvoran]

I think these will need csi.enabled=true set since by default the csi daemonset is not deployed in the chart.

Suggested change

	local actual=$(helm template \
	--show-only templates/csi-daemonset.yaml \
	. | tee /dev/stderr |
	local actual=$(helm template \
	--show-only templates/csi-daemonset.yaml \
	--set 'csi.enabled=true' \
	. | tee /dev/stderr |

[shuyanl-qualtrics]

done

[tvoran]

Suggested change

	local actual=$(helm template \
	--show-only templates/csi-daemonset.yaml \
	--set 'csi.hostNetwork=true' \
	. | tee /dev/stderr |
	local actual=$(helm template \
	--show-only templates/csi-daemonset.yaml \
	--set 'csi.enabled=true' \
	--set 'csi.hostNetwork=true' \
	. | tee /dev/stderr |

[shuyanl-qualtrics]

done

[tvoran]

nit: formatting

Suggested change

	#Allow modification of the hostNetwork parameter to avoid the need of a dedicated pod ip
	# Allow modification of the hostNetwork parameter to avoid the need of a
	# dedicated pod ip

[shuyanl-qualtrics]

done

[tvoran]

nit: These are in alphabetical order, so it would be good to move this to be after hmacSecretName.

[shuyanl-qualtrics]

done

[tvoran]

Can you also review similar PR for CSI-Driver : kubernetes-sigs/secrets-store-csi-driver#1581 Thank you (also comments in that repo for a question regarding value update)

Sorry, that chart is beyond my purview.

[shuyanl-qualtrics]

all comments fixed @tvoran Please help take a look. Thank you

[tvoran]

Thanks!