Updated the ConfigMap Annotation Hook

[aakash21]

The ConfigMap Annotation has been incorrectly mentioned in the values.yaml file, as https://github.com/hashicorp/vault-helm/blob/main/templates/_helpers.tpl#L462 states that it is expecting the boolean value of includeConfigAnnotation

  {{- if .Values.server.includeConfigAnnotation }}
        vault.hashicorp.com/config-checksum: {{ include "vault.config" . | sha256sum }}
  {{- end }}

Instead in values.yaml the hook has been specified as configAnnotation: false which is not being used, For Reference: https://github.com/hashicorp/vault-helm/blob/main/values.yaml#L676

After updating this value to true, the checksum annotation could be created in the Stateful Set.

annotations:
  vault.hashicorp.com/config-checksum: 3961301403b088XXXXXXXXXXX

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[tvoran]

Good catch, thanks for opening this! Would you mind updating that option in values.schema.json as well?

We could also add a bats test to check the default value in test/unit/server-statefulset.bats; I think we can get the default value from helm show values . and parse the output with yq. If that's something you'd like to add, let us know! Otherwise we can add it in a separate PR.

[aakash21]

@tvoran i have modified the schema.json but in the test/unit/server-statefulset.bats the test case for this hook is already present https://github.com/hashicorp/vault-helm/blob/main/test/unit/server-statefulset.bats#L1702

  cd `chart_dir`
  local actual=$(helm template \
      --show-only templates/server-statefulset.yaml \
      --set 'server.includeConfigAnnotation=true' \
      . | tee /dev/stderr |
      yq '.spec.template.metadata.annotations["vault.hashicorp.com/config-checksum"] == null' | tee /dev/stderr)
  [ "${actual}" = "false" ]
}```

[tvoran]

Looks like the parameter in values.yaml was updated as part of #1049, so I'm going to close this for now. Thanks!