Skip to content

Commit

Permalink
comment fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
shuyanl-qualtrics committed Aug 26, 2024
1 parent 330b64c commit 529e788
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
8 changes: 5 additions & 3 deletions test/unit/csi-daemonset.bats
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@ load _helpers
cd `chart_dir`
local actual=$(helm template \
--show-only templates/csi-daemonset.yaml \
--set 'csi.enabled=true' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.hostNetwork' | tee /dev/stderr)
[ "${actual}" = "false" ]
Expand All @@ -550,9 +551,10 @@ load _helpers
@test "server/StatefulSet: server.hostNetwork is set" {
cd `chart_dir`
local actual=$(helm template \
--show-only templates/csi-daemonset.yaml \
--set 'csi.hostNetwork=true' \
. | tee /dev/stderr |
--show-only templates/csi-daemonset.yaml \
--set 'csi.enabled=true' \
--set 'csi.hostNetwork=true' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.hostNetwork' | tee /dev/stderr)
[ "${actual}" = "true" ]
}
Expand Down
6 changes: 3 additions & 3 deletions values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@
"hmacSecretName": {
"type": "string"
},
"hostNetwork": {
"type": "boolean"
},
"image": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -197,9 +200,6 @@
"resources": {
"type": "object"
},
"hostNetwork": {
"type": "boolean"
},
"serviceAccount": {
"type": "object",
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ csi:
# generating secret versions.
hmacSecretName: ""

#Allow modification of the hostNetwork parameter to avoid the need of a dedicated pod ip
# Allow modification of the hostNetwork parameter to avoid the need of a dedicated pod ip
hostNetwork: false

# Settings for the daemonSet used to run the provider.
Expand Down

0 comments on commit 529e788

Please sign in to comment.