Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement to better handle long message formats. #30

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enhancement to better handle long message formats. #30

wants to merge 1 commit into from

Conversation

hcrhall
Copy link
Contributor

@hcrhall hcrhall commented Jun 11, 2024 •
edited
Loading

PR includes tests for the report.sentinel module as well as a few amendments to the format that will hopefully improve the way in which we share long form messages with users.

Changes include:

  • Moved the violation message into a new section at the top of print statement called "Overview:"
  • Expanded the violation map to include a new value call action which is used to provide a succinct call to action.

Output:
image

Ganeshrockz
Ganeshrockz approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Ganeshrockz Ganeshrockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ganeshrockz Ganeshrockz Ganeshrockz approved these changes

@aahel aahel Awaiting requested review from aahel

@absolutelightning absolutelightning Awaiting requested review from absolutelightning

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcrhall @Ganeshrockz