feat: support default_extensions_template in SSH #2361
+96
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the default_extensions_template parameter in SSH backend role resource.
fairclothjm
requested changes
Nov 12, 2024
| @@ -243,6 +248,12 @@ func sshSecretBackendRoleWrite(d *schema.ResourceData, meta interface{}) error { | |||
| data["default_extensions"] = v | |||
| } | |||
|
|
|||
| if provider.IsAPISupported(meta, provider.VaultVersion180) { | |||
| if v, ok := d.GetOk("default_extensions_template"); ok { | |||
There was a problem hiding this comment.
We should use d.Get() for booleans. If you test the update path I think you may find that d.GetOk() does not update the field.
Comment on lines
+38
to
+39
| VaultVersion180 = version.Must(version.NewSemver(consts.VaultVersion110)) | ||
| VaultVersion190 = version.Must(version.NewSemver(consts.VaultVersion190)) |
There was a problem hiding this comment.
These are unsupported Vault versions. We need not add checks for them
| @@ -243,6 +248,12 @@ func sshSecretBackendRoleWrite(d *schema.ResourceData, meta interface{}) error { | |||
| data["default_extensions"] = v | |||
| } | |||
|
|
|||
| if provider.IsAPISupported(meta, provider.VaultVersion180) { | |||
There was a problem hiding this comment.
This is an unsupported Vault version. We need not add a check for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support the
default_extensions_templateparameter in SSH backend role resource.Relates OR Closes #0000
Checklist
Output from acceptance testing:
Community Note