Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TTL field #2318

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Added TTL field #2318

merged 8 commits into from
Nov 11, 2024

Conversation

Gaardsholt
Copy link
Contributor

@Gaardsholt Gaardsholt commented Sep 5, 2024 •
edited
Loading

Description

Added ttl to vault_gcp_secret_impersonated_account resource

Fixes: #1812

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests were run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@Gaardsholt
added TTL field
ea25d8a 
Signed-off-by: Lasse Gaardsholt <[email protected]>
@Gaardsholt Gaardsholt marked this pull request as ready for review September 5, 2024 10:18
@Gaardsholt
Copy link
Contributor Author

Can I do anything to get someone to look at this one? :)

@Gaardsholt
Copy link
Contributor Author

👋 👋

fairclothjm
fairclothjm requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Gaardsholt! Can add some test coverage for this as well as a Changelog entry?

@Gaardsholt
Added Computed: True to TTL
35bfed6 
Signed-off-by: Lasse Gaardsholt <[email protected]>
@Gaardsholt
redundant since false is the default
ac737b2 
Signed-off-by: Lasse Gaardsholt <[email protected]>
@Gaardsholt
Added changlog entry
4eca33a 
Signed-off-by: Lasse Gaardsholt <[email protected]>
@Gaardsholt Gaardsholt force-pushed the vault_gcp_secret_impersonated_account-ttl branch from d7d57d3 to 4eca33a Compare November 7, 2024 21:13
@Gaardsholt
Copy link
Contributor Author

Thanks for the contribution @Gaardsholt! Can add some test coverage for this as well as a Changelog entry?

I have tried adding tests and a changelog entry :)

@Gaardsholt
is this enough to read it?
6d492bf 
Signed-off-by: Lasse Gaardsholt <[email protected]>
@fairclothjm fairclothjm added this to the 4.5.0 milestone Nov 11, 2024
fairclothjm
fairclothjm approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gaardsholt !

@fairclothjm fairclothjm merged commit 4cfc26e into hashicorp:main Nov 11, 2024
1 check passed
@Gaardsholt Gaardsholt deleted the vault_gcp_secret_impersonated_account-ttl branch November 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

vault_gcp_secret_impersonated_account resource does not support ttl parameter
2 participants
@Gaardsholt @fairclothjm