Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth/kubernetes: add support for use_annotations_as_alias_metadata field #2226

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Apr 19, 2024

Description

Closes #2224
Closes #2213

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

@fairclothjm
Copy link
Contributor Author

I thought this would be a quick one but I need to sort out the failing tests. Converting to draft for now

@Shocktrooper
Copy link

Hello! Just checking in on the progress for this work as I was waiting for 4.3.0 to be released. If its going to be a bit could we move this to the next release possibly so 4.3.0 could be released?

@vinay-gopalan vinay-gopalan removed this from the 4.3.0 milestone May 30, 2024
@c0deaddict
Copy link

For which release is this planned? We are waiting on this.

@c0deaddict
Copy link

@fairclothjm any chance this can be included in the next release? 🙏

@fairclothjm fairclothjm force-pushed the VAULT-26286/kube-auth-use-annotations-field branch from 2b2ec73 to c9d5a8e Compare November 4, 2024 15:51
@fairclothjm fairclothjm marked this pull request as ready for review November 4, 2024 16:40
@fairclothjm fairclothjm added this to the 4.5.0 milestone Nov 4, 2024
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fairclothjm fairclothjm merged commit 3418cb7 into main Nov 4, 2024
11 checks passed
@fairclothjm fairclothjm deleted the VAULT-26286/kube-auth-use-annotations-field branch November 4, 2024 17:31
@fairclothjm
Copy link
Contributor Author

Thanks!

@fairclothjm
Copy link
Contributor Author

@Shocktrooper @c0deaddict Sorry for the delay on this one! This should make it into the next release, v4.5.0

@c0deaddict
Copy link

Thank you @fairclothjm 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add use_annotations_as_alias_metadata to the vault_kubernetes_auth_backend_config
5 participants