Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing GitHub resources #2124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

czembower
Copy link
Contributor

Description

Updates resource_github_auth_backend, resource_github_team, and resource_github_user to handle resources present in state but missing from Vault configuration.

For resource_github_auth_backend, authMountInfoGet was simply relocated to occur after checking for the existence of the mount. Comments inline for the other two changes.

Closes #2123

Output from acceptance testing:

=== RUN TestAccGithubTeam_basic
--- PASS: TestAccGithubTeam_basic (1.85s)
=== RUN TestAccGithubTeam_teamConfigError
--- PASS: TestAccGithubTeam_teamConfigError (0.12s)
=== RUN TestAccGithubTeam_importBasic
--- PASS: TestAccGithubTeam_importBasic (1.30s)
PASS

=== RUN TestAccGithubUser_basic
--- PASS: TestAccGithubUser_basic (1.70s)
=== RUN TestAccGithubUser_importBasic
--- PASS: TestAccGithubUser_importBasic (1.16s)
PASS

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@github-actions github-actions bot added the size/S label Jan 9, 2024
@fairclothjm
Copy link
Contributor

Thanks @czembower ! Sorry for the delay on this one! We have recently updated vault/resource_github_auth_backend.go which I think partially resolves your issue. Would you mind rebasing on main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GitHub auth resources not recreated if deleted outside of Terraform
2 participants