-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CNAME resolution tree (CNAME recursivity) to the dns_cname_record… #389
Add CNAME resolution tree (CNAME recursivity) to the dns_cname_record… #389
Conversation
8120f5e
to
87cebe5
Compare
…_set datasource Signed-off-by: Tony Fouchard <[email protected]>
87cebe5
to
bed642e
Compare
Hi @hightoxicity 👋 Thank you for submitting this. Interesting use case -- would you be able to open a feature request that describes the "why" of this a little better please? e.g.
From a design perspective, another thing I'd like to poke at is whether it is more or less confusing to have a resource that does both a single lookup ( In the meantime, if anyone else is interested in this use case, please 👍 on the original PR description which can help us with prioritization. |
Hi @bflad , thanks for your very qualitative and fast inputs, it seems like a great idea to create a new datasource for this special usecase, I am about to close this PR and replace it by #390 that I think is cleaner and I will fill all the information you need in this new PR in coming days. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
…_set datasource
It is actually hard to achieve recursivity with Terraform.
If at some time we want to follow a CNAME tree in Terraform it is near impossible to do it dynamically and find final leaf.
This feature would allow to get a CNAME full path to final leaf CNAME and allow to use those intermediate found elements to do some ops, here in Docusign, we need to know if one of those intermediate element cross a host that has "akadns.net." suffix (akamai global traffic management property) to add some controls to our Terraform GTM Automation.
I put one of our record to test, but we need to get a similar fixture record under hashicorptest.com and adapt the test for this.
Thx for your help/review/feedback