-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_linux_function_app: Update WEBSITE_CONTENTSHARE when is user defined #28521
base: main
Are you sure you want to change the base?
azurerm_linux_function_app: Update WEBSITE_CONTENTSHARE when is user defined #28521
Conversation
…lue. Updated test to validate the proper update of WEBSITE_CONTENTSHARE
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxFunctionApp_ -timeout 360m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
--- FAIL: TestAccLinuxFunctionApp_authV2AzureActiveDirectory (406.56s)
--- FAIL: TestAccLinuxFunctionApp_authV2UpgradeFromV1 (1544.87s)
--- FAIL: TestAccLinuxFunctionApp_appStackNode (404.25s)
--- FAIL: TestAccLinuxFunctionApp_authV2Update (210.14s)
--- FAIL: TestAccLinuxFunctionApp_authV2AzureActiveDirectoryRemove (247.54s) |
Community Note
Description
When the Azure function is created without
WEBSITE_CONTENTSHARE
defined, an automatic value is assigned since is mandatory to have it, and to avoid overwrite it on each deployment, the code is reading the current value and updating the user data. But, when the setting was defined by the user, the described behaviour was causing the situation described in the linked issue: the value being never updated.To solve the problem, I have altered the steps to make it as follow:
The only gap that remains present is in the scenario when the setting was defined initially by the user and then removed from the config (it will never be replaced by a generated one).
Updated also 2 test to verify that the value is updated.
PR Checklist
Changes to existing Resource / Data Source
Testing
Note: Logs are quite long, so I will add it in a comment. There are some failures but are caused by limited access to run it or pre-existing problems in the tests.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_linux_function_app
- Update WEBSITE_CONTENTSHARE when is user defined. [azurerm_linux_function_app: Update WEBSITE_CONTENTSHARE when is user defined #28521]This is a (please select all that apply):
Related Issue(s)
Fixes #28434
Note
If this PR changes meaningfully during the course of review please update the title and description as required.