Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_logic_app_standard - fix setting public_network_access for conflicting API properties #28465

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Jan 9, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Fixes a bug in setting publicNetworkAccess due to this being set in two places currently which can conflict with each other and cause inconsistent behaviour.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_logic_app_standard - fix setting public_network_access for conflicting API properties

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Closes #27398

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions bot added size/S and removed size/XS labels Jan 13, 2025
Co-authored-by: stephybun <[email protected]>
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops LGTM 🐗

@jackofallops
Copy link
Member Author

Tests look good:

image

@jackofallops jackofallops merged commit 002a108 into main Jan 13, 2025
31 checks passed
@jackofallops jackofallops deleted the b/logic-app-pna-again branch January 13, 2025 13:37
@github-actions github-actions bot added this to the v4.16.0 milestone Jan 13, 2025
jackofallops added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_logic_app_standard does not have an argument for Microsoft.Web/sites/publicNetworkAccess
2 participants