New resource: azurerm_netapp_volume_group_oracle
#28391
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm-provider-azurerm into pmarques/avg-oracle
github-actions
bot
added
waiting-response
enhancement
and removed
waiting-response
labels
mbfrahry
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Hey @paulomarquesc, I took a look over this PR and it mostly seems fine. My main concern is that existing tests are being changed which might lead to breaking changes. Can you confirm that migrating from the current version of the provider to this version doesn't cause issues?
internal/services/netapp/validate/volume_group_oracle_volumes_validation.go
Outdated
Show resolved
Hide resolved
internal/services/netapp/validate/volume_group_oracle_volumes_validation.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Frahry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR implements a new Azure NetApp Files resource called Volume Group for Oracle.
On top of implementing the new resource
azurerm_netapp_volume_group_oracle, it also contains the following changes/improvements:azurerm_netapp_volume_group_oracle- new resource implementation with resource, data source, unit tests, acceptance tests and documentation/examples.azurerm_netapp_volume- changedVolumesBreakReplicationThenPolltoVolumesBreakReplicationdue to issue LRO Polling fails from time to time pandora#4571azurerm_netapp_volume_quota_rule- included wait functionwaitForQuotaRuleCreateOrUpdateto make sure resource completes its updates.azurerm_netapp_volume_group_sap_hana- case refactored in multiple place to be more consist with golang same is true to the data source code, modified configurationdata_protection_snapshot_policyforcomputed = truedue to an issue with terraform not properly identifying the deletion graph and ending up trying to delete a snapshot policy before the volumes, causing issues with acceptance tests and resource destruction, this is due to volumes in AVG being listed inside a list. Made a specific function to expand volumes calledexpandNetAppVolumeGroupSAPHanaVolumesso it can be independent of the Oracle one due to a few major differences.ValidateNetAppVolumeGroupExportPolicyRuleSAPHannais now renamed toValidateNetAppVolumeGroupExportPolicyRuleand shared with Oracle AVG.azurerm_netapp_snapshot_policy- implemented handling for the 409 issue when terraform tries to delete the snapshot policy before the volumes using it are being handled so it can disassociate the volumes from itself before deletion.PR Checklist
Changes to existing Resource / Data Source
Testing
Unit tests execution:
Acceptance tests results:
Acceptance tests retry for the 3 initially failed tests:
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_netapp_volume_group_oracle- new resourceazurerm_netapp_volume- changedVolumesBreakReplicationThenPolltoVolumesBreakReplicationdue to issue LRO Polling fails from time to time pandora#4571azurerm_netapp_volume_quota_rule- included wait functionwaitForQuotaRuleCreateOrUpdateto make sure resource completes its updates.azurerm_netapp_snapshot_policy- implemented handling for the 409 issue when terraform tries to delete the snapshot policy before the volumes using it are being handled so it can disassociate the volumes from itself before deletion.This is a (please select all that apply):