feat: add kusto_eventhub_data_connection supports retrieval_start_date parameter

[FakieHeelflip]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add for the kusto_eventhub_data_connection the parameter "retrieval_start_date" to ingest older stored data from an Event Hub.

When defined, the data connection retrieves existing Event hub events created since the Retrieval start date. It can only retrieve events retained by the Event hub, based on its retention period.

• add the missing parameter for CRUD
• add test case for the new parameter
• add updated docs

Made CRUD tests locally.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_kusto_eventhub_data_connection - support the retrieval_start_date parameter

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

No known open issue for that.

[FakieHeelflip]

Besides, it is not clear to me what tests you need from me to approve that PR.

[FakieHeelflip]

Thank you for triggering the checks. There were indeed a format errors (spaces) in the Terraform blocks of the website documentation and in the test file for the azurerm_kusto_eventhub_data_connection. Used terraform fmt for both of the resource blocks to fix.

[FakieHeelflip]

Hello, politely asking what I can do to get things merged? :)

[FakieHeelflip]

All checks have passed. Who can review and merge it? :)

[catriona-m]

Hi @FakieHeelflip thanks for submitting this. I left one minor comment here, but once that is addressed I can take another look. Thanks!

[FakieHeelflip]

Hi @catriona-m , thank you for the review. You are right, totally overlooked that validation function. Thanks. Commited your suggestion.

[catriona-m]

Hi @FakieHeelflip thanks for updating the validation on this. I ran the tests on this and it looks like this property is causing some failures that would need to be address before we can merge this:

Copy to clipboard
------- Stdout: -------
=== RUN   TestAccKustoEventHubDataConnection_databaseRoutingType
=== PAUSE TestAccKustoEventHubDataConnection_databaseRoutingType
=== CONT  TestAccKustoEventHubDataConnection_databaseRoutingType
    testcase.go:173: Step 1/3 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # azurerm_kusto_eventhub_data_connection.test will be updated in-place
          ~ resource "azurerm_kusto_eventhub_data_connection" "test" {
                id                      = "/subscriptions/*******/resourceGroups/acctestRG-250110120520846318/providers/Microsoft.Kusto/clusters/acctestkco721m/databases/acctestkd-250110120520846318/dataConnections/acctestkedc-250110120520846318"
                name                    = "acctestkedc-250110120520846318"
              - retrieval_start_date    = "2025-01-10T12:18:51.7164161Z" -> null
                # (11 unchanged attributes hidden)
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccKustoEventHubDataConnection_databaseRoutingType (1130.62s)
FAIL

[FakieHeelflip]

Hi @catriona-m , do I need to do something?

[FakieHeelflip]

@catriona-m I am again confused what to do... could you please help?