tools/importer-rest-api-specs: splitting the dataapigeneratorjson package into transforms and stages
#3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added
tool/importer-rest-api-specs
…epository models out into it's own package This both makes the migration to the new models simpler (since it's contained within one package) but also means the parent package can be tidied per Phase 10
…o split the transforms and file writing This both enables reuse (for graph in time) and allows us to switch over to the Data API SDK models
…m wasn't pulled out for a CSV type
…n` package to split the Generator and Transform stages
tombuildsstuff
force-pushed
the
refactor/9-arm-importer-transforms-and-sdk-models
branch
from
eaef0a7 to
45db742
Compare
catriona-m
approved these changes
Feb 21, 2024
| } | ||
|
|
||
| // NOTE: `Parent` types don't get a `TypeHintIn` or `TypeHintValue` | ||
| // meaning that only |
There was a problem hiding this comment.
is this comment missing a bit 🤔 ?
There was a problem hiding this comment.
It is (it's a lift and shift) - but this is actually fixed in one of the follow up PR's so I'm gonna leave this for now
tombuildsstuff
deleted the
refactor/9-arm-importer-transforms-and-sdk-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
dataapigeneratorjsonpackage in two ways:resourcemanagertypes into thedataapimodelstypes) into it's own package (transforms).filesystemtype (similar to how theimporter-msgraph-metadatalogic works) - the intention here is to allow both testability (since we can validate the files exist at the paths we're expecting more easily) and that this type can be reused when loading the data from disk too.This PR also makes the indentation consistent across all of the generated API Definitions - which means that when this PR is merged the regeneration is going to be fairly large but will only contain whitespace - but means that the API Definitions are consistent going forwards.
This PR represents a preparation stage for Phase 9 and 10 of #3754