Allow approving documents in Approved status (#415)

hashicorp-forge · Nov 9, 2023 · cf5b0a8 · cf5b0a8
1 parent 2f39473
commit cf5b0a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/api/approvals.go b/internal/api/approvals.go
@@ -354,9 +354,9 @@ func ApprovalHandler(
 
 			// Authorize request.
 			userEmail := r.Context().Value("userEmail").(string)
-			if doc.Status != "In-Review" && doc.Status != "In Review" {
+			if doc.Status != "In-Review" && doc.Status != "Approved" {
 				http.Error(w,
-					"Only documents in the \"In-Review\" status can be approved",
+					`Document status must be "In-Review" or "Approved" to approve`,
 					http.StatusBadRequest)
 				return
 			}

diff --git a/internal/api/v2/approvals.go b/internal/api/v2/approvals.go
@@ -390,9 +390,9 @@ func ApprovalsHandler(srv server.Server) http.Handler {
 
 			// Authorize request.
 			userEmail := r.Context().Value("userEmail").(string)
-			if doc.Status != "In-Review" && doc.Status != "In Review" {
+			if doc.Status != "In-Review" && doc.Status != "Approved" {
 				http.Error(w,
-					"Only documents in the \"In-Review\" status can be approved",
+					`Document status must be "In-Review" or "Approved" to approve`,
 					http.StatusBadRequest)
 				return
 			}