Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC3 fixes #69

Merged
merged 3 commits into from
Nov 7, 2023
Merged

RC3 fixes #69

merged 3 commits into from
Nov 7, 2023

Conversation

svienot
Copy link
Contributor

@svienot svienot commented Nov 7, 2023

Description:

This brings a few minor changes:

  • update the patch for h5ai-nginx sub-module to:
    • fix initialisation error in the select-contract-form
    • add a patch for the inlined h5ai project to remove the "Open repo in Remix" link
  • remove the footer mention "Once a contract is verified it can't be removed..."

Related issue(s):

Fixes #64 #65

@svienot svienot self-assigned this Nov 7, 2023
@svienot svienot requested a review from Nana-EC November 7, 2023 15:14
Fix initialization bug in select-contract-form (issue #64)

Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our parts look good :)

hedera-patch/h5ai-nginx.patch Show resolved Hide resolved
@svienot svienot merged commit 923aec9 into main Nov 7, 2023
2 checks passed
@svienot svienot deleted the rc3-fixes branch November 7, 2023 18:15
svienot added a commit that referenced this pull request Nov 7, 2023
Signed-off-by: Simon Viénot <[email protected]>
(cherry picked from commit 923aec9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong chain ID for mainnet during verification lookups
2 participants