Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for smart contract verification #570

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yaroslav-007
Copy link
Contributor

@yaroslav-007 yaroslav-007 commented Mar 21, 2024

Description:
Add support for smart contract verification

Related issue(s):

Fixes #558

Notes for reviewer:
Currently a draft. Issues in #558 are raised that needs to be addressed first.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@yaroslav-007 yaroslav-007 linked an issue Mar 21, 2024 that may be closed by this pull request
@yaroslav-007 yaroslav-007 self-assigned this Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.31%. Comparing base (e9e73a6) to head (94d892e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   51.31%   51.31%           
=======================================
  Files          24       24           
  Lines        1179     1179           
  Branches      136      136           
=======================================
  Hits          605      605           
  Misses        550      550           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaroslav-007 yaroslav-007 force-pushed the 558-add-support-for-smart-contract-verification branch from 94d892e to 9d18425 Compare June 5, 2024 13:38
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

Copy link

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

timeout: 10s
retries: 10

sourcify-sourcify-ui:
Copy link

@acuarica acuarica Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be consistent with the other names we could use

Suggested change
sourcify-sourcify-ui:
sourcify-ui:

### Prometheus ####
PROMETHEUS_IMAGE_NAME=prom/prometheus
PROMETHEUS_IMAGE_TAG=v2.41.0

### Grafana ####
GRAFANA_IMAGE_NAME=grafana/grafana
GRAFANA_IMAGE_TAG=8.5.16

### Sourcify ####
SOURCIFY_TAG=main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin to a specific version, e.g., 0.3.0?

SOURCIFY_NODE_ENV=development

#Sourcify ui
SOURCIFY_UI_PORT=1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use the same external port that hedera-sourcify uses for ui, i.e., 3001?

https://github.com/hashgraph/hedera-sourcify/blob/e313ed01504026ad6e0884b786da2a20c3305593/.env#L7

It's better if we provide a consistent DX across repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for smart contract verification
3 participants