-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for smart contract verification #570
base: main
Are you sure you want to change the base?
feat: Add support for smart contract verification #570
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=======================================
Coverage 51.31% 51.31%
=======================================
Files 24 24
Lines 1179 1179
Branches 136 136
=======================================
Hits 605 605
Misses 550 550
Partials 24 24 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Signed-off-by: Yaroslav Markovski <[email protected]>
Signed-off-by: Yaroslav Markovski <[email protected]>
Signed-off-by: Yaroslav Markovski <[email protected]>
94d892e
to
9d18425
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
timeout: 10s | ||
retries: 10 | ||
|
||
sourcify-sourcify-ui: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be consistent with the other names we could use
sourcify-sourcify-ui: | |
sourcify-ui: |
### Prometheus #### | ||
PROMETHEUS_IMAGE_NAME=prom/prometheus | ||
PROMETHEUS_IMAGE_TAG=v2.41.0 | ||
|
||
### Grafana #### | ||
GRAFANA_IMAGE_NAME=grafana/grafana | ||
GRAFANA_IMAGE_TAG=8.5.16 | ||
|
||
### Sourcify #### | ||
SOURCIFY_TAG=main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pin to a specific version, e.g., 0.3.0
?
SOURCIFY_NODE_ENV=development | ||
|
||
#Sourcify ui | ||
SOURCIFY_UI_PORT=1234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use the same external port that hedera-sourcify
uses for ui
, i.e., 3001
?
https://github.com/hashgraph/hedera-sourcify/blob/e313ed01504026ad6e0884b786da2a20c3305593/.env#L7
It's better if we provide a consistent DX across repos.
Description:
Add support for smart contract verification
Related issue(s):
Fixes #558
Notes for reviewer:
Currently a draft. Issues in #558 are raised that needs to be addressed first.
Checklist