-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added design docs for eth_sendRawTransaction fast transaction hash return #3282
docs: added design docs for eth_sendRawTransaction fast transaction hash return #3282
Conversation
…ash return Signed-off-by: Logan Nguyen <[email protected]>
Test Results 19 files - 1 244 suites - 33 31m 48s ⏱️ + 1m 26s For more details on these failures, see this check. Results for commit 82e6bbf. ± Comparison against base commit 3a9b577. This pull request removes 5 tests.
♻️ This comment has been updated with latest results. |
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
=======================================
Coverage 77.89% 77.89%
=======================================
Files 66 66
Lines 4470 4470
Branches 1003 1003
=======================================
Hits 3482 3482
Misses 613 613
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
This PR introduces a design document detailing additional aspects of the new feature that allows
eth_sendRawTransaction
to immediately return the transaction hash after passing all prechecks.Related issue(s):
More aspects and considerations of the feature are highlighted in the ongoing discussion in #3202. Please feel free to share your insights in the thread if you have any.
Fixes #3281
Notes for reviewer:
Checklist