Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added design docs for eth_sendRawTransaction fast transaction hash return #3282

Conversation

quiet-node
Copy link
Member

Description:
This PR introduces a design document detailing additional aspects of the new feature that allows eth_sendRawTransaction to immediately return the transaction hash after passing all prechecks.

Related issue(s):
More aspects and considerations of the feature are highlighted in the ongoing discussion in #3202. Please feel free to share your insights in the thread if you have any.

Fixes #3281

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 20, 2024
@quiet-node quiet-node added this to the 0.61.0 milestone Nov 20, 2024
@quiet-node quiet-node self-assigned this Nov 20, 2024
@quiet-node quiet-node requested a review from a team as a code owner November 20, 2024 22:29
Copy link

github-actions bot commented Nov 20, 2024

Test Results

 19 files   -  1  244 suites   - 33   31m 48s ⏱️ + 1m 26s
608 tests  -  5  603 ✅ + 3  4 💤 ±0  1 ❌  - 8 
699 runs  +39  694 ✅ +47  4 💤 ±0  1 ❌  - 8 

For more details on these failures, see this check.

Results for commit 82e6bbf. ± Comparison against base commit 3a9b577.

This pull request removes 5 tests.
"before all" hook for "transfers the requested amount" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance when the token owner has enough balance "before all" hook for "transfers the requested amount"
"before all" hook for "transfers the requested amount" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance when the token owner has enough balance "before all" hook for "transfers the requested amount"
"before all" hook in "@api-batch-2 RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before all" hook in "@api-batch-2 RPC Server Acceptance Tests"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is the zero address "before each" hook for "reverts"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is the zero address "before each" hook for "reverts"

♻️ This comment has been updated with latest results.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@quiet-node quiet-node merged commit bde69e3 into main Nov 22, 2024
44 of 46 checks passed
@quiet-node quiet-node deleted the 3281-eth_sendrawtransaction-fast-return-create-a-design-doc-for-fast-return-feature branch November 22, 2024 17:00
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (3a9b577) to head (82e6bbf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3282   +/-   ##
=======================================
  Coverage   77.89%   77.89%           
=======================================
  Files          66       66           
  Lines        4470     4470           
  Branches     1003     1003           
=======================================
  Hits         3482     3482           
  Misses        613      613           
  Partials      375      375           
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.64% <ø> (ø)
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eth_sendRawTransaction Fast Return] Create a design doc for fast return feature
3 participants