Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds retry to send raw transaction (#3161) #3208

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ebadiere
Copy link
Collaborator

@ebadiere ebadiere commented Nov 4, 2024

Addresses issue: #3160

  • Adds retry to eth send raw transaction

  • Adds mirror node check before retry and expands SDKClientError object to include transactionId

  • Adds unit tests

  • Adds improvements

  • adds relevant comment for hardcoded values

  • removes retry and adds mirror node check in the sdk client

  • Adds unit tests

  • Addresses PR comments

  • Changes the error thrown when timeout occurs to SDKClientError

  • Ensure other error types are thrown


Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ebadiere ebadiere added the enhancement New feature or request label Nov 4, 2024
@ebadiere ebadiere self-assigned this Nov 4, 2024
@ebadiere ebadiere added this to the 0.59.0 milestone Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Test Results

 22 files  + 2  271 suites  +17   35m 27s ⏱️ + 3m 17s
605 tests ± 0  594 ✅  -  3  4 💤 ±0  7 ❌ +3 
646 runs  +16  634 ✅ +13  4 💤 ±0  8 ❌ +3 

For more details on these failures, see this check.

Results for commit 0609b17. ± Comparison against base commit 90bf36a.

♻️ This comment has been updated with latest results.

* Adds retry to eth send raw transaction

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Adds mirror node check before retry and expands SDKClientError object to include transactionId

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Adds unit tests

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Adds improvements

Signed-off-by: Konstantina Blazhukova <[email protected]>

* adds relevant comment for hardcoded values

Signed-off-by: Konstantina Blazhukova <[email protected]>

* removes retry and adds mirror node check in the sdk client

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Adds unit tests

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Addresses PR comments

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Changes the error thrown when timeout occurs to SDKClientError

Signed-off-by: Konstantina Blazhukova <[email protected]>

* Ensure other error types are thrown

Signed-off-by: Konstantina Blazhukova <[email protected]>

---------

Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
@ebadiere ebadiere force-pushed the 3160-cherry-pick-handle-timeout branch from 79d5247 to 0609b17 Compare November 4, 2024 18:15
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ebadiere ebadiere merged commit 01c893a into release/0.59 Nov 4, 2024
41 of 45 checks passed
@ebadiere ebadiere deleted the 3160-cherry-pick-handle-timeout branch November 4, 2024 21:12
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (90bf36a) to head (0609b17).
Report is 1 commits behind head on release/0.59.

Files with missing lines Patch % Lines
packages/relay/src/lib/clients/sdkClient.ts 39.13% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.59    #3208      +/-   ##
================================================
- Coverage         83.35%   83.16%   -0.20%     
================================================
  Files                66       66              
  Lines              4290     4312      +22     
  Branches            837      843       +6     
================================================
+ Hits               3576     3586      +10     
- Misses              473      483      +10     
- Partials            241      243       +2     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 85.28% <48.14%> (-0.26%) ⬇️
server 83.52% <ø> (ø)
ws-server 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/errors/SDKClientError.ts 78.26% <100.00%> (+2.07%) ⬆️
.../relay/src/lib/services/hapiService/hapiService.ts 78.26% <100.00%> (ø)
packages/relay/src/lib/clients/sdkClient.ts 57.31% <39.13%> (-1.54%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants