-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adds retry to send raw transaction (#3161) #3208
Conversation
Test Results 22 files + 2 271 suites +17 35m 27s ⏱️ + 3m 17s For more details on these failures, see this check. Results for commit 0609b17. ± Comparison against base commit 90bf36a. ♻️ This comment has been updated with latest results. |
* Adds retry to eth send raw transaction Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds mirror node check before retry and expands SDKClientError object to include transactionId Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds unit tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds improvements Signed-off-by: Konstantina Blazhukova <[email protected]> * adds relevant comment for hardcoded values Signed-off-by: Konstantina Blazhukova <[email protected]> * removes retry and adds mirror node check in the sdk client Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds unit tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Addresses PR comments Signed-off-by: Konstantina Blazhukova <[email protected]> * Changes the error thrown when timeout occurs to SDKClientError Signed-off-by: Konstantina Blazhukova <[email protected]> * Ensure other error types are thrown Signed-off-by: Konstantina Blazhukova <[email protected]> --------- Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Eric Badiere <[email protected]>
79d5247
to
0609b17
Compare
Quality Gate failedFailed conditions |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.59 #3208 +/- ##
================================================
- Coverage 83.35% 83.16% -0.20%
================================================
Files 66 66
Lines 4290 4312 +22
Branches 837 843 +6
================================================
+ Hits 3576 3586 +10
- Misses 473 483 +10
- Partials 241 243 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Addresses issue: #3160
Adds retry to eth send raw transaction
Adds mirror node check before retry and expands SDKClientError object to include transactionId
Adds unit tests
Adds improvements
adds relevant comment for hardcoded values
removes retry and adds mirror node check in the sdk client
Adds unit tests
Addresses PR comments
Changes the error thrown when timeout occurs to SDKClientError
Ensure other error types are thrown
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist