Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added e2e tests for multiple users across various tiers #3190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: added e2e tests for multiple users across various tiers #3190

wants to merge 4 commits into from
+201 −29

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Oct 31, 2024 •
edited
Loading

Description:
This PR adds e2e tests for multiple users across various tiers

Related issue(s):

Fixes #3068

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the Internal For changes that affect the project's internal workings but not its outward-facing functionality. label Oct 31, 2024
@quiet-node quiet-node added this to the 0.60.0 milestone Oct 31, 2024
@quiet-node quiet-node self-assigned this Oct 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Test Results

 22 files  + 4  290 suites  +37   36m 13s ⏱️ + 6m 47s
609 tests + 6  601 ✅ + 4  4 💤 ±0  4 ❌ +2 
774 runs  +42  765 ✅ +39  4 💤 ±0  5 ❌ +3 

For more details on these failures, see this check.

Results for commit 7d2ca9e. ± Comparison against base commit 0e31b34.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 3068-v2-hbar-rate-limit-redesign-create-e2e-tests-for-multiple-usrs-with-different-spending-plans branch from a409ddb to 5cf6d5c Compare November 1, 2024 15:39
@quiet-node quiet-node marked this pull request as ready for review November 1, 2024 15:39
victor-yanev
victor-yanev reviewed Nov 4, 2024
View reviewed changes
packages/server/tests/acceptance/hbarLimiter.spec.ts
Comment on lines +735 to +738
const accountCreatedResult = await createAliasAndAssociateSpendingPlan(
subscriptionTier as SubscriptionTier,
);
accountPlanObject[subscriptionTier].push(accountCreatedResult);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to confirm that multiple accounts can be associated with the same HbarSpendingPlan, contributing to a common shared budget

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good point!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victor-yanev added coverage to confirm the above! Good catch!

@quiet-node quiet-node force-pushed the 3068-v2-hbar-rate-limit-redesign-create-e2e-tests-for-multiple-usrs-with-different-spending-plans branch from 5cf6d5c to 1b544d8 Compare November 4, 2024 18:09
ebadiere
ebadiere reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick question around the Utils.wait.

@quiet-node
fix: removed wait
7d2ca9e 
Signed-off-by: Logan Nguyen <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (0e31b34) to head (7d2ca9e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3190   +/-   ##
=======================================
  Coverage   83.16%   83.17%           
=======================================
  Files          66       66           
  Lines        4312     4314    +2     
  Branches      843      843           
=======================================
+ Hits         3586     3588    +2     
  Misses        483      483           
  Partials      243      243
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 85.29% <ø> (+<0.01%) ⬆️
server 83.52% <ø> (ø)
ws-server 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

ebadiere
ebadiere approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadiere ebadiere ebadiere approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87 AlfredoG87 is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC Nana-EC is a code owner

@victor-yanev victor-yanev Awaiting requested review from victor-yanev

At least 2 approving reviews are required to merge this pull request.

Assignees

@quiet-node quiet-node

Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.

[HBAR Rate Limit Redesign] Create e2e tests for multiple users with different spending plans
3 participants
@quiet-node @ebadiere @victor-yanev