-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated .github/release.yaml to include internal
and github_action
labeled PRs
#3175
base: main
Are you sure you want to change the base?
Conversation
Kindly check this and merge before 31 |
internal
and github_action
labeled PRs
Hey @Ritesh-Udgata, thanks for picking this up and working on it—great job! A few points (only
|
@Ritesh-Udgata Ah also another thing could you please kindly make a random comment on the issue #3172 so I can assign the ticket to you? |
a731cea
to
bcf247f
Compare
Done 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the work!
Could You please add hacktoberfest accepted label ? Thanks. |
@Ritesh-Udgata Hi could you kindly rebase and force pushed the branch? We just added an option which skips the |
I've added the labels. Could you tell me if it's missing anything? |
bcf247f
to
4d85c05
Compare
Kindly add Hacktober fest accepted label |
@Ritesh-Udgata I have added all these labels Are there any other labels you need me to add? |
internal
and github_action
labeled PRsinternal
and github_action
labeled PRs
Hello @Ritesh-Udgata, the PR Check/Title Check is still failing. Upon reviewing the workflow file, it appears to be the old version of the YAML file. Please rebase with the remote main branch and force push again to bypass the workflow job. |
4d85c05
to
b042709
Compare
@Ritesh-Udgata Hmm I still see the old version of the YAML file. I'm looking at your forked repo, the release branch indicates that your branch is 13 commits behind the remote |
b042709
to
3d1a9b4
Compare
@Ritesh-Udgata I see you forced push again but seems like your forked repo is still 16 commits behind remote:main. |
@Ritesh-Udgata looks like you have updated your forked git checkout release
git rebase main
git push -f This should update your |
Signed-off-by: Ritesh <[email protected]>
3d1a9b4
to
441c95e
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3175 +/- ##
===========================================
- Coverage 82.36% 59.61% -22.76%
===========================================
Files 69 65 -4
Lines 4475 4269 -206
Branches 881 855 -26
===========================================
- Hits 3686 2545 -1141
- Misses 538 1345 +807
- Partials 251 379 +128
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description:
This PR modified the .github/release.yaml to include
internal
andgithub_action
labeled PRsFixes #3172
Notes for reviewer:
Checklist