Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated .github/release.yaml to include internal and github_action labeled PRs #3175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ritesh-Udgata
Copy link

@Ritesh-Udgata Ritesh-Udgata commented Oct 29, 2024

Description:
This PR modified the .github/release.yaml to include internal and github_action labeled PRs

Fixes #3172

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Ritesh-Udgata
Copy link
Author

Kindly check this and merge before 31

@quiet-node quiet-node changed the title Updated .github/release.yaml chore: updated .github/release.yaml to include internal and github_action labeled PRs Oct 30, 2024
@quiet-node quiet-node added the Internal For changes that affect the project's internal workings but not its outward-facing functionality. label Oct 30, 2024
@quiet-node quiet-node added this to the 0.60.0 milestone Oct 30, 2024
@quiet-node
Copy link
Member

Kindly check this and merge before 31

Hey @Ritesh-Udgata, thanks for picking this up and working on it—great job!

A few points (only 1 and 2 require changes from you):

  1. It appears the DCO check didn’t pass. Please review the Sign Off section in the contributing guide to learn more about signing your commit. For this case, you can fix the DCO by running the following commands:

    git rebase HEAD~1 --signoff
    git push -f
  2. This commit also needs to be signed with your GPG key. Here’s a helpful resource: Signing Commits.

  3. The PR title doesn’t align with the conventional format. There’s a CI check that verifies this, so it’s essential to follow the Conventional Commits standard. I’ve updated the title for you this time but it's jsut FYI for your future contributions 😉

  4. Lastly, a more descriptive PR description is preferred. Again, I’ve updated it for you as an FYI for future contributions, so no worries!

@quiet-node
Copy link
Member

@Ritesh-Udgata Ah also another thing could you please kindly make a random comment on the issue #3172 so I can assign the ticket to you?

@Ritesh-Udgata
Copy link
Author

Done 👍

  • Added sign off along with gpg key
  • More descriptive PR

@quiet-node quiet-node added good first issue Good for newcomers good first issue candidate Issues that can become a good first issue but need more description/context. hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. labels Oct 30, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the work!

@Ritesh-Udgata
Copy link
Author

Could You please add hacktoberfest accepted label ? Thanks.

@quiet-node
Copy link
Member

@Ritesh-Udgata Hi could you kindly rebase and force pushed the branch? We just added an option which skips the PR Check/Title Checkj CI job if it's from a forked repo.

@quiet-node
Copy link
Member

Could You please add hacktoberfest accepted label ? Thanks.

I've added the labels. Could you tell me if it's missing anything?

@Ritesh-Udgata
Copy link
Author

Kindly add Hacktober fest accepted label

@quiet-node
Copy link
Member

Kindly add Hacktober fest accepted label

@Ritesh-Udgata I have added all these labels
image

Are there any other labels you need me to add?

@quiet-node quiet-node changed the title chore: updated .github/release.yaml to include internal and github_action labeled PRs fix: updated .github/release.yaml to include internal and github_action labeled PRs Oct 31, 2024
@quiet-node
Copy link
Member

quiet-node commented Oct 31, 2024

Hello @Ritesh-Udgata, the PR Check/Title Check is still failing. Upon reviewing the workflow file, it appears to be the old version of the YAML file. Please rebase with the remote main branch and force push again to bypass the workflow job.

@quiet-node
Copy link
Member

@Ritesh-Udgata Hmm I still see the old version of the YAML file. I'm looking at your forked repo, the release branch indicates that your branch is 13 commits behind the remote hashgraph:main. Could you please update your branch and push it again?

@quiet-node
Copy link
Member

@Ritesh-Udgata I see you forced push again but seems like your forked repo is still 16 commits behind remote:main.

image

@quiet-node
Copy link
Member

@Ritesh-Udgata looks like you have updated your forked main branch but didn't update your release. Please run below to update your release:

git checkout release
git rebase main
git push -f

This should update your release branch and should fix the problem.

Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.61%. Comparing base (f540496) to head (441c95e).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f540496) and HEAD (441c95e). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (f540496) HEAD (441c95e)
config-service 1 0
relay 1 0
server 1 0
ws-server 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3175       +/-   ##
===========================================
- Coverage   82.36%   59.61%   -22.76%     
===========================================
  Files          69       65        -4     
  Lines        4475     4269      -206     
  Branches      881      855       -26     
===========================================
- Hits         3686     2545     -1141     
- Misses        538     1345      +807     
- Partials      251      379      +128     
Flag Coverage Δ
config-service ?
relay ?
server ?
ws-server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 52 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release.yml to include internal and github_action labeled PRs
3 participants