chore: add active users counter per rate limiter duration #3150

nadezhdapopovaa · 2024-10-23T13:43:42Z

Description:
Add counter for active users based on the rate limiter duration period.

Related issue(s):

Fixes #3151

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-10-23T13:47:36Z

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 27,888 ms

Heap Statistics (before vs after executing the test):

Total Heap Size: increased with 1.46 MB
Total Heap Size Executable: no changes
Total Physical Size: decreased with 348.16 KB
Total Available Size: decreased with 4.20 MB
Total Global Handles Size: no changes
Used Global Handles Size: decreased with 64.00 bytes
Used Heap Size: decreased with 3.44 MB
Heap Size Limit: no changes
Malloced Memory: no changes
External Memory: no changes
Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

Old Space:
- Space Size: increased with 1.84 MB
- Space Used Size: increased with 2.08 MB
- Space Available Size: decreased with 7.09 MB
- Physical Space Size: increased with 1.84 MB
Large Object Space:
- Space Size: increased with 835.58 KB
- Space Used Size: increased with 813.50 KB
- Space Available Size: no changes
- Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

github-actions · 2024-10-23T13:48:08Z

Test Results

17 files - 4 229 suites - 48 29m 25s ⏱️ - 4m 14s
603 tests - 2 599 ✅ + 3 4 💤 ±0 0 ❌ - 5
619 runs - 251 615 ✅ - 245 4 💤 - 1 0 ❌ - 5

Results for commit 9ae5db5. ± Comparison against base commit ca044f1.

This pull request removes 2 tests.

"before all" hook in "@precompile-calls Tests for eth_call with HTS" ‑ RPC Server Acceptance Tests Acceptance tests @precompile-calls Tests for eth_call with HTS "before all" hook in "@precompile-calls Tests for eth_call with HTS"
"before each" hook for "should execute "eth_getStorageAt" request to get old state with passing specific block" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get old state with passing specific block"

♻️ This comment has been updated with latest results.

natanasow

LGTM

Nana-EC

Good change but not sure it's at the right level and might have side effects

Nana-EC · 2024-10-25T15:34:27Z

packages/relay/src/lib/services/hbarLimitService/index.ts

+    this.register.removeSingleMetric(activeUsersPerLimitPeriodCounterName);
+    this.activeUsersPerLimitPeriodCounter = new Counter({
+      name: activeUsersPerLimitPeriodCounterName,
+      help: 'Relay Hbar rate limiter active users counter',


note this isn't specific to the spending plan.
This should be in general, it just happens that eth_sendRawTransaction and others might spend hBAR.
Does have it in the spending plan mean we'd miss calls that don't spend HBAR.
Maybe this should be placed higher up in the server?

Nana-EC · 2024-10-25T15:36:03Z

packages/relay/src/lib/services/hbarLimitService/index.ts

+   * @private
+   */
+  private resetActiveUsers(): void {
+    this.activeUsersPerLimitPeriodCounter.reset();


I don't think we should be resetting in code.
Shouldn't we be able to group this within the metric collection tool e.g. Grafana
For instance if the duration is not 24hrs the intent breaks

Signed-off-by: Nadezhda Popova <[email protected]>

sonarcloud · 2024-11-05T14:41:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-11-05T17:41:48Z

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (ca044f1) to head (9ae5db5).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/server/src/server.ts	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3150      +/-   ##
==========================================
- Coverage   83.11%   83.09%   -0.03%     
==========================================
  Files          66       66              
  Lines        4312     4317       +5     
  Branches      843      845       +2     
==========================================
+ Hits         3584     3587       +3     
- Misses        485      486       +1     
- Partials      243      244       +1

Flag	Coverage Δ
config-service	`98.14% <ø> (ø)`
relay	`85.23% <ø> (ø)`
server	`83.35% <66.66%> (-0.18%)`	⬇️
ws-server	`36.87% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/server/src/server.ts	`71.05% <66.66%> (-0.22%)`	⬇️

ebadiere

Is there a way to have this managed by the metrics service?

nadezhdapopovaa linked an issue Oct 23, 2024 that may be closed by this pull request

[HBAR Rate Limit Redesign] Add a counter to expose DAU metrics. #3109

Open

nadezhdapopovaa force-pushed the 3109-hbar-rate-limit-redesign-add-a-counter-to-expose-dau-metrics branch from c40af15 to 9c52deb Compare October 24, 2024 09:37

nadezhdapopovaa self-assigned this Oct 24, 2024

nadezhdapopovaa added the enhancement New feature or request label Oct 24, 2024

nadezhdapopovaa added this to the 0.59.0 milestone Oct 24, 2024

natanasow previously approved these changes Oct 24, 2024

View reviewed changes

nadezhdapopovaa marked this pull request as ready for review October 25, 2024 15:02

nadezhdapopovaa requested review from AlfredoG87, ebadiere, lukelee-sl and a team as code owners October 25, 2024 15:02

Nana-EC requested changes Oct 25, 2024

View reviewed changes

ebadiere modified the milestones: 0.59.0, 0.60.0 Oct 30, 2024

nadezhdapopovaa dismissed natanasow’s stale review via 540fdca November 5, 2024 14:14

nadezhdapopovaa force-pushed the 3109-hbar-rate-limit-redesign-add-a-counter-to-expose-dau-metrics branch from 9c52deb to 540fdca Compare November 5, 2024 14:14

nadezhdapopovaa added 4 commits November 5, 2024 16:40

chore: add active users counter per rate limiter duration

1d89042

Signed-off-by: Nadezhda Popova <[email protected]>

test: update tests to include active users counter

d37b4f6

Signed-off-by: Nadezhda Popova <[email protected]>

fixup! chore: add active users counter per rate limiter duration

89afb3d

Signed-off-by: Nadezhda Popova <[email protected]>

fixup! test: update tests to include active users counter

9ae5db5

Signed-off-by: Nadezhda Popova <[email protected]>

nadezhdapopovaa force-pushed the 3109-hbar-rate-limit-redesign-add-a-counter-to-expose-dau-metrics branch from 540fdca to 9ae5db5 Compare November 5, 2024 14:40

ebadiere reviewed Nov 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add active users counter per rate limiter duration #3150

chore: add active users counter per rate limiter duration #3150

nadezhdapopovaa commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

natanasow left a comment

Nana-EC left a comment

Nana-EC Oct 25, 2024

Nana-EC Oct 25, 2024

sonarcloud bot commented Nov 5, 2024

codecov bot commented Nov 5, 2024

ebadiere left a comment

chore: add active users counter per rate limiter duration #3150

Are you sure you want to change the base?

chore: add active users counter per rate limiter duration #3150

Conversation

nadezhdapopovaa commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited Loading

🚨 Memory Leak Detected 🚨

Details

Recommendations

github-actions bot commented Oct 23, 2024 • edited Loading

Test Results

natanasow left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC Oct 25, 2024

Choose a reason for hiding this comment

Nana-EC Oct 25, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Nov 5, 2024

Quality Gate passed

codecov bot commented Nov 5, 2024

Codecov Report

ebadiere left a comment

Choose a reason for hiding this comment

nadezhdapopovaa commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading