-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added redis in docker-compose #3107
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
leaved some nits.
@sahil9001 | when you do so the hint: you will need to force push, once you configure your GPG Key do the following:
The git reset the last commit but keeps the changes (soft) 👍 |
4424b1f
to
a47f78a
Compare
349acb1
to
9f82371
Compare
@AlfredoG87 can you check here? I don't have the option to ask for re-review :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 2 nits.
PS: it would be cool if you can add some screenshots of the docker containers running, and its env context when running the docker compose with this change. You can put these screenshots on the PR Description under "Notes for reviewer" section.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3107 +/- ##
==========================================
- Coverage 83.16% 79.72% -3.45%
==========================================
Files 63 65 +2
Lines 4236 4232 -4
Branches 830 840 +10
==========================================
- Hits 3523 3374 -149
- Misses 470 577 +107
- Partials 243 281 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hey @sahil9001 , thanks for your contribution, this is great. |
Signed-off-by: Sahil Silare <[email protected]>
bada091
to
039d029
Compare
done buddy, thanks for this. I learnt this new thing today! |
Don't forget to add a blank line at the end of the file. 👍 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TYVM for your contribution 💯
No, as you can see you can still see the |
Signed-off-by: Sahil Silare <[email protected]>
Signed-off-by: Sahil Silare <[email protected]>
Fixed, is this eligible for hacktoberfest swags? @AlfredoG87 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, tyvm for your contribution @sahil9001
Description:
This PR adds redis to the docker-compose so that both servers can share the cache among themselves.
Related issue(s):
Fixes #1869
Notes for reviewer:
Docker Containers up & running :
Environmental variables :
Checklist